| time |
nick |
message |
09:56 |
<edelln> |
gertv: ping |
09:56 |
<gertv> |
edelln: hi |
09:57 |
<edelln> |
I am trying to determine if what the jbi-maven-plugin is generating is correct |
09:57 |
<edelln> |
it now generates zip for the SA and not a jar |
09:58 |
<edelln> |
I looked at the GenerateServiceAssemblyMojo and it does seem to create a zip |
09:58 |
<gertv> |
but isn't that renamed once it is moved in the maven repo? |
09:58 |
<gertv> |
in the install phase that is |
09:59 |
<edelln> |
but if you build eg. bridge locally and look in the target directory it now builds a zip so i guess it only copies a zip - the SU's look to be correct in that they have a zip and jar |
10:00 |
<edelln> |
but if I look at an old kit as of the 11th of July and build the bridge sample for the SA it builds a SA locally |
10:00 |
<edelln> |
that is a jar file |
10:02 |
<edelln> |
and the zip thats generated doesn't have any license, notice, pom.xml etc |
10:04 |
<gertv> |
there might be some other things missing in the pom.xml files for the demo's to include those |
10:05 |
<gertv> |
are they necessary -- since the user is building these demos herself, there's is no need for license files, is there? |
10:05 |
<gertv> |
does the zip file have a meta-inf/jbi.xml and the correct SU packaging inside? |
10:07 |
<gertv> |
and the generated zip file definitely shouldn't have a pom.xml in there |
10:11 |
<edelln> |
yes it has the correct su packaging and jbi.xml and it actually does have a pom |
10:13 |
<gertv> |
well, looking at the code, it seems to have been changed to zip a while ago |
10:13 |
<gertv> |
http://svn.eu.apache.org/.../GenerateServiceAssemblyMojo.java?sortdir=down&r1=551602&r2=594352&pathrev=614100 |
10:13 |
<gertv> |
but the SMX3 trunk will probably still have used the already published 3.2.1 plugin there |
10:13 |
<gertv> |
we haven't had a SMX release at apache since then |
10:14 |
<edelln> |
yeah maybe it is meant to be a zip now but I just wanted to check - I will build a kit and test it for sure |
10:15 |
<ffang> |
edelln: gertv: I built kit this morning and yeah, the zip SA works quite well |
10:16 |
<edelln> |
we should document things like this in a migration section on the wiki |
10:29 |
<gertv> |
edelln: like this -- http://cwiki.apache.org/confluence/display/SMX4/Migrating+from+ServiceMix+3? |
11:01 |
<edelln> |
excellant thanks! |
14:13 |
<gertv> |
gnodet: if you want to get rid of the jar-plugin in the plexus/components.xml |
14:13 |
<gertv> |
gnodet: you probably can do that by calling project.getArtifact().setFile(//zip file here), followed by my patch to the jbi SU mojo |
