| time |
nick |
message |
16:01 |
<Udai> |
Hi ralf |
16:06 |
<Udai> |
I want to know if there is some arithmetic expression like exp + exp can we name it in our implementation as left + right |
16:48 |
<ralf> |
hi udai |
16:48 |
<Udai> |
hi |
16:48 |
<Udai> |
are you working on the current patch? |
16:49 |
<ralf> |
as far as i recall the UML does Add extend CompoundExpression |
16:49 |
<ralf> |
and CompoundExpression has a list of expressions |
16:49 |
<Udai> |
Add extends ArithmeticExpression |
16:50 |
<ralf> |
so all the expressions in the list get added in the sequence they are in the list |
16:50 |
<ralf> |
imho classes involved are |
16:51 |
<ralf> |
Add, Subtract, Multiply, Divide |
16:51 |
<Udai> |
Concat and Reminder I have added |
16:51 |
<Udai> |
for || and % |
16:52 |
<ralf> |
AdditiveExpression (AE), MultiplicativeExpression (ME), CompoundExpression |
16:52 |
<ralf> |
forgot Reminder and Concat |
16:52 |
<ralf> |
Add extends AE |
16:52 |
<ralf> |
Subtract extends AE |
16:52 |
<ralf> |
Concat extends AE |
16:53 |
<ralf> |
Multiply extends ME |
16:53 |
<ralf> |
Divide extends ME |
16:53 |
<ralf> |
Reminder extends ME |
16:53 |
<ralf> |
AE extends CE |
16:53 |
<ralf> |
ME extends CE |
16:53 |
<Udai> |
I am able to print a string like this...... |
16:54 |
<ralf> |
CE has a list of expressions |
16:54 |
<Udai> |
SELECT o.bar FROM org.castor.cpa.query.Foo AS o WHERE (((((o.position - 4) + 4.0) * 6) / 5) = 3) |
16:55 |
<ralf> |
how would a+b+c+d look like |
16:55 |
<Udai> |
do you think its correct |
16:56 |
<Udai> |
well insteed of using this list approch I have used a tree approch |
16:56 |
<ralf> |
i expect it would be (((a + b) + c) + d) which is not the best solution |
16:56 |
<Udai> |
so that () can be placed at right position |
16:57 |
<ralf> |
and your example could be (((o.position - 4 + 4.0) * 6 / 5) = 3) |
16:58 |
<Udai> |
okay |
16:59 |
<Udai> |
well the design AE, ME and CE was not there in UML |
16:59 |
<ralf> |
to know when () is needed ME and AE are used |
16:59 |
<Udai> |
there was ArithmeticExpression |
17:00 |
<Udai> |
yes |
17:00 |
<Udai> |
I think you are right |
17:00 |
<Udai> |
all these will be in expression package |
17:01 |
<ralf> |
it was there at condition but as far as i recall your code you did not implement is this way |
17:02 |
<ralf> |
having said that i didn't review that in detail yet |
17:02 |
<Udai> |
Add, Divide, Multiply, Subtract extends ArithmeticExpression |
17:02 |
<Udai> |
ArithmeticExpression extend AbstractExpression |
17:03 |
<Udai> |
these were in expression package |
17:03 |
<ralf> |
yes i know |
17:03 |
<Udai> |
not in condition |
17:03 |
<Udai> |
even in UML |
17:04 |
<Udai> |
we never talked about AE, ME and CE before this...or did we? |
17:04 |
<ralf> |
no we didn't |
17:04 |
<Udai> |
k |
17:04 |
<Udai> |
so I will go for this now |
17:06 |
<Udai> |
just let me know when you will start working on patch so that I can attach the patch just before that .....in the mean while I can improve it if something comes in my mind |
17:06 |
<ralf> |
i have seen your patch from earlier today |
17:07 |
<Udai> |
but I have added few more things here at my code base |
17:07 |
<ralf> |
i will merge its condition, expression and function packages as i have done only small changes to them |
17:07 |
<Udai> |
I think this AE M and CE thing is left |
17:08 |
<ralf> |
at which packages have you added things |
17:08 |
<Udai> |
expression and condition |
17:09 |
<ralf> |
okay |
17:09 |
<ralf> |
will ping you before i merge |
17:09 |
<Udai> |
So do you think I can replace the new patch with the old one or I should just put the new one |
17:10 |
<Udai> |
@ping: that will be great.... |
17:13 |
<ralf> |
will be out for some time now |
17:13 |
<ralf> |
see you later |
18:56 |
<ralf> |
forgot that i have to do some other things before review |
18:56 |
<Udai> |
okay |
18:57 |
<ralf> |
if you leave before i return attach a new patch to 2442 before |
18:57 |
<Udai> |
k |
20:08 |
<Udai> |
I have attached the patch....I will be leaving now... |
20:08 |
<Udai> |
see you tomorrow |
