hi udai

hi ralf

I have few things to ask and tell you

about temporalType

as DateExpression, TimeExpression and TimestampExpression are the temporalType

for Condition equal(final TemporalType temporalType, final Date value) and Condition equal(final TemporalType temporalType, final Calendar value) {

in implementation I will be using java.sql.Date, Time and Timestamp

java.util.Date and Calendar are more general datatypes

I will be breaking them acc to tempralType during the implementation

I have renamed property start to index with getter and setters in Substring function according to the Expression interface substring defination

I have renamed properties start to index and search to value with getter and setters in Locate function according to the Expression interface Locate defination

about the enum OrderDirective

ASCENDING should be ACS and DESCENDING should be DESC so that they can be converted into toString method directly

I will mention these points when I would attach the new patch that will contain whole QO package

do you have any comments on these right now??

will be out for lunch.....

I will be back soon....

okay, sounds fine by me

also out for lunch

udai: will be back in about an hour to look at parts of your work

if you will not be online at that time please send me a mail what you prefer where i should start

for your information. I'll be offline tomorrow but plan to continue review of your work at sunday

hope to see you later

ralf??

hi udai

i'm back now

hi

how are things going

glad to see you back

just fine

I hope you got the mail

just checking my mails

k

okay. i'll look at 2442

and for methods like equal(final TemporalType temporalType, final Date value)

here you have took value as java.util.Date

and java.util.Calendar;

that's according to EJB specification

where?

can you please point me there

at query interface of EJB you have several methods to bind values to parameters

and they use the same TemporalType and Date or Calendar

k

i'll check

cause I was considering the string format for date, time and timestamp

page 66

okay

it's always difficult to find the best way to work with dates

k then I will workout the implementation acc to them

I will format the Date to string acc ot our specification

same for others

i see 3 options

when converting them toString

use java.sql types or java.util.Date or Calendar to store them internally

while java.sql types and java.util.Date are good for transforming them to string

has Calendar advantages when we need to compare date values

ya

if we use java.util.Date we save quite some code as we can move property and getters/setters into an abstract class

but suppose if user need to set the Date

then what input will he give

a string

then we can convert that into any type

user has to use SelectQuery interface to create a new DateExpression

so we provide him like

we do not plan that he uses the implementations

DateExpression.setDate(Date)

if he just want to DateExpression.setDate((String)"yyyymmdd")

as far as i recall at the moment there is a createDate(TemporalType, java.util.Date) method at Select interface

no, we do not provide such methods

are you sure?

he can use DateFormat to parse string into Date himself

k

I don't see this createDate method I think I will include it

problem is that we could only support a fixed format for parsing dates

yes you are right

so its better to keep such logic outside

the createDate method need to be added in SelectQuery interface

will do that

i defined it somewhere

maybe its in QueryFactory

okay I will see that

i have not opened eclipse yet to check myself

but i'm sure it is defined somewhere

no problem

you just open the last patch and search "createDate"

maybe you are right that it is better to use java.sql.Date at DateExpression

as this gives us more type savety

I think I will give some more reasons why we can use which

as I have to do a little bit research on them

and the EJB implementation

okay

so we meet on sunday

yes

so I guess I will go to bed now

I am missing my breakfast ;)

i will help a friend with repairing some things at his house tomorrow

and in the evening will ahve a small barbecue party

okay :)

;-)

see you on sunday

enjoy

see you

bbye